chia7712 commented on code in PR #843: URL: https://github.com/apache/yunikorn-core/pull/843#discussion_r1566308424
########## Makefile: ########## @@ -200,6 +200,9 @@ build: commands # Run the tests after building .PHONY: test +test: export DEADLOCK_DETECTION_ENABLED = true +test: export DEADLOCK_TIMEOUT_SECONDS = 10 +test: export DEADLOCK_EXIT = true Review Comment: Should we always make `DEADLOCK_EXIT` be true if we are running the deadlock detection? I means we don't need to have extra env variable (DEADLOCK_EXIT) to enable to exit the program in deadlocking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
