chia7712 commented on code in PR #846:
URL: https://github.com/apache/yunikorn-core/pull/846#discussion_r1572184716
##########
pkg/scheduler/objects/application.go:
##########
@@ -695,6 +695,10 @@ func (sa *Application) RecoverAllocationAsk(ask
*AllocationAsk) {
zap.Error(err))
}
}
+
+ if ask.IsPlaceholder() {
Review Comment:
Could we extract those behavior to a new method and then let
`RecoverAllocationAsk` and `AddAllocationAsk` reuse that method? That can avoid
that `RecoverAllocationAsk` and `AddAllocationAsk` have diverged in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
