ryankert01 opened a new pull request, #848:
URL: https://github.com/apache/yunikorn-core/pull/848

   ### What is this PR for?
   The update of setting a template on a parent could fail if the template is 
not correct. The error is swallowed and a success is returned but the update of 
the queue has not finished correctly:  
   *Queue.applyConf()
   ```go
   if !sq.isLeaf {
       if err = sq.setTemplate(conf.ChildTemplate); err != nil {
          return nil
       }
   } 
   ```
   I also add tests to make sure we do not regress.
   
   ### What type of PR is it?
   * [x] - Bug Fix
   * [ ] - Improvement
   * [ ] - Feature
   * [ ] - Documentation
   * [ ] - Hot Fix
   * [ ] - Refactoring
   
   ### Todos
   N/A
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/YUNIKORN-2482 
   
   ### How should this be tested?
   
   ```
   go test -timeout 30s -run ^TestApplyConf$ 
github.com/apache/yunikorn-core/pkg/scheduler/objects
   ```
   
   ### Screenshots (if appropriate)
   N/A
   
   ### Questions:
   N/A
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to