chenyulin0719 commented on code in PR #851:
URL: https://github.com/apache/yunikorn-core/pull/851#discussion_r1573676347
##########
pkg/common/configs/configvalidator.go:
##########
@@ -356,24 +356,20 @@ func checkPlacementRules(partition *PartitionConfig)
error {
return nil
}
-func checkQueueHierarchyForPlacement(path []string, create, hasDynamicPart
bool, conf []QueueConfig, parentConf *QueueConfig) (result
placementPathCheckResult, lastQueueName string) {
+func checkQueueHierarchyForPlacement(path []string, create, hasDynamicPart
bool, conf []QueueConfig, parentConf *QueueConfig) (placementPathCheckResult,
string) {
queueName := path[0]
- lastQueueName = ""
Review Comment:
Hi @plsmaop,
Could we keep the variable lastQueueName alive in this function? My concern
is for readability. When I look back at checkQueueHierarchyForPlacement(), it's
quite difficult to fugure out that the second string is lastQueueName.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
