chenyulin0719 commented on code in PR #423:
URL: https://github.com/apache/yunikorn-site/pull/423#discussion_r1574078788


##########
docs/user_guide/queue_config.md:
##########
@@ -395,6 +395,7 @@ There is no guaranteed resource setting for the root queue.
 
 Maximum resources when configured place a hard limit on the size of all 
allocations that can be assigned to a queue at any point in time.
 A maximum resource can be set to 0 which makes the resource not available to 
the queue.
+However, setting all maximum resources to zero will be ignored and logged for 
debugging.

Review Comment:
   I just noticed that setting all the maximum resource to 0 does not simply 
get ignored. 
   If a maximum resource setting already exists in the queue, the previous 
setting will be cleared.
   
   This behavior is not documented too. 
   
   
https://github.com/apache/yunikorn-core/blob/ff654b2dd9038c1b026d99e553f79cd32e3d4de7/pkg/scheduler/objects/queue.go#L407-L408



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to