ryankert01 commented on code in PR #823: URL: https://github.com/apache/yunikorn-k8shim/pull/823#discussion_r1575571824
########## pkg/cache/context_test.go: ########## @@ -49,16 +49,46 @@ import ( ) const ( - Host1 = "HOST1" - appID1 = "app00001" - appID2 = "app00002" - appID3 = "app00003" -) + // NOTE: why this variable is public of package Review Comment: I don't think it should be public, but the name `host1` will be duplicate to this variable: https://github.com/apache/yunikorn-k8shim/blob/741c0d801ac4530669b8850706efe3f0bc0d5718/pkg/cache/context_test.go#L610-L611 So, a rename is needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
