chia7712 commented on code in PR #830:
URL: https://github.com/apache/yunikorn-k8shim/pull/830#discussion_r1589036866
##########
pkg/cache/application_state.go:
##########
@@ -50,13 +50,12 @@ const (
KilledApplication
ReleaseAppAllocation
ReleaseAppAllocationAsk
- AppStateChange
ResumingApplication
AppTaskCompleted
)
func (ae ApplicationEventType) String() string {
- return [...]string{"SubmitApplication", "RecoverApplication",
"AcceptApplication", "TryReserve", "UpdateReservation", "RunApplication",
"RejectApplication", "CompleteApplication", "FailApplication",
"KillApplication", "KilledApplication", "ReleaseAppAllocation",
"ReleaseAppAllocationAsk", "AppStateChange", "ResumingApplication",
"AppTaskCompleted"}[ae]
Review Comment:
Could you please add unit test to keep consistency between enum and string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
