chia7712 commented on code in PR #863:
URL: https://github.com/apache/yunikorn-core/pull/863#discussion_r1589873284
##########
pkg/common/configs/configvalidator_test.go:
##########
@@ -2012,3 +2012,227 @@ func TestCheckQueuesStructure(t *testing.T) {
})
}
}
+
+func TestCheckQueues(t *testing.T) { //nolint:funlen
+ testCases := []struct {
+ name string
+ queue *QueueConfig
+ level int
+ errorExpected bool
Review Comment:
It seems `validateFunc` is not called if `errorExpected` is true. Maybe we
can merge them to simplify code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
