chia7712 commented on code in PR #826:
URL: https://github.com/apache/yunikorn-k8shim/pull/826#discussion_r1594942299
##########
pkg/cache/context.go:
##########
@@ -663,35 +663,31 @@ func (ctx *Context) IsPodFitNode(name, node string,
allocate bool) error {
return err
}
-func (ctx *Context) IsPodFitNodeViaPreemption(name, node string, allocations
[]string, startIndex int) (index int, ok bool) {
+func (ctx *Context) IsPodFitNodeViaPreemption(name, node string, allocations
[]string, startIndex int) (int, bool) {
// assume minimal pods need killing if running in testing mode
if ctx.apiProvider.IsTestingMode() {
- return startIndex, ok
+ return startIndex, false
Review Comment:
I guess @wilfred-s is going to merge it, so please ignore my comment :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
