chenyulin0719 commented on code in PR #857:
URL: https://github.com/apache/yunikorn-core/pull/857#discussion_r1594988514
##########
pkg/scheduler/placement/rule_test.go:
##########
@@ -52,6 +52,15 @@ func TestNewRule(t *testing.T) {
if err != nil || nr == nil {
t.Errorf("new normalised newRule build failed which should not,
newRule 'nil' , err: %v, ", err)
}
+
+ // test normalise newRule name
Review Comment:
nit: this comment is redundant. (The new added test is for 'recovery' rule
in config, not for normalise rule name. )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
