pbacsko commented on PR #838: URL: https://github.com/apache/yunikorn-k8shim/pull/838#issuecomment-2105557568
Thanks for the patch @jacobsalway. I'm wondering if it makes sense to enhance test coverage for this. We could implement a mock for `cache.SharedIndexInformer` because all informer returns this type when you call `Informer()`. Then we can validate if `HasSynced()` and `Run()` has been called, so `client.Clients` becomes testable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
