wilfred-s commented on code in PR #842:
URL: https://github.com/apache/yunikorn-k8shim/pull/842#discussion_r1607563190
##########
pkg/cache/context.go:
##########
@@ -601,25 +601,18 @@ func (ctx *Context) deletePriorityClass(obj interface{}) {
}
func (ctx *Context) triggerReloadConfig(index int, configMap *v1.ConfigMap) {
- ctx.lock.Lock()
- defer ctx.lock.Unlock()
-
- conf := ctx.apiProvider.GetAPIs().GetConf()
- if !conf.EnableConfigHotRefresh {
+ // hot reload is turned off do nothing
+ // hot reload can be turned off by an update: safety first access under
lock to prevent data race
+ if !ctx.apiProvider.GetAPIs().GetConf().IsConfigReloadable() {
Review Comment:
removed the call and use scheduler conf directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
