SophieTech88 opened a new pull request, #846: URL: https://github.com/apache/yunikorn-k8shim/pull/846
### What is this PR for? if task is not found, a nil is returned from context.getTask in for response.New processing we should just log that fact and proceed to the next alloc. Simplifies the flow as we never need to check for a. nil task. We should never have a pod in the cache that does not exist as a task on an application. We retrieve the application using the application ID from the response to never use the object. We only use the application ID to pass into an event. The context event handler then does the exact same lookup again to process the event on the app. We need to become much smarter in this area, double or triple lookups, generate async events that just change the state of the app or task or kick off another event. Actions: * Check the task, if task == nil, make a logging and skip that loop and jump to next iteration. * Retrieve the application using the application ID from the response ### What type of PR is it? * [ ] - Bug Fix * [x] - Improvement * [ ] - Feature * [ ] - Documentation * [ ] - Hot Fix * [ ] - Refactoring ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/YUNIKORN-2618 ### How should this be tested? It should pass all CI tests. I tested locally. It passed all CI tests and e2e test. ### Screenshots (if appropriate) ### Questions: * [ ] - The licenses files need update. * [ ] - There is breaking changes for older versions. * [ ] - It needs documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
