chenyulin0719 opened a new pull request, #848:
URL: https://github.com/apache/yunikorn-k8shim/pull/848
### What is this PR for?
- Also check below annotations in updatePodLabel
1. yunikorn.apache.org/app-id (Annotation)
2. yunikorn.apache.org/queue (Annotation)
- Remove magic number. (use constants.LabelApplicationID,
constants.LabelQueueName...)
### What type of PR is it?
* [x] - Bug Fix
### Todos
NA
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2636
### How should this be tested?
1. make test.
3. Follow the reproduce steps in the Jira description
### Screenshots (if appropriate)
- No applicationId/queue lable added by admission controller
<img width="1120" alt="image"
src="https://github.com/apache/yunikorn-k8shim/assets/26764036/f24a847b-a12c-4cf1-a33f-84aa6dc11038";>
- The pod is placed to the correct queue. 'root.sandbox'
<img width="707" alt="image"
src="https://github.com/apache/yunikorn-k8shim/assets/26764036/4eff055a-f354-4b93-9d9e-0f40140ed3bf";>
### Questions:
NA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
