pbacsko commented on code in PR #868:
URL: https://github.com/apache/yunikorn-core/pull/868#discussion_r1611426456


##########
pkg/scheduler/objects/allocation_ask.go:
##########
@@ -79,7 +79,7 @@ func NewAllocationAsk(allocationKey string, applicationID 
string, allocatedResou
                resKeyPerNode:     make(map[string]string),
        }
        aa.resKeyWithoutNode = reservationKeyWithoutNode(applicationID, 
allocationKey)
-       aa.askEvents = newAskEvents(aa, events.GetEventSystem())
+       aa.askEvents = newAskEvents(events.GetEventSystem())
        return aa

Review Comment:
   Done



##########
pkg/scheduler/objects/allocation_ask.go:
##########
@@ -108,7 +108,7 @@ func NewAllocationAskFromSI(ask *si.AllocationAsk) 
*AllocationAsk {
                return nil
        }
        saa.resKeyWithoutNode = reservationKeyWithoutNode(ask.ApplicationID, 
ask.AllocationKey)
-       saa.askEvents = newAskEvents(saa, events.GetEventSystem())
+       saa.askEvents = newAskEvents(events.GetEventSystem())

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to