pbacsko commented on code in PR #871:
URL: https://github.com/apache/yunikorn-core/pull/871#discussion_r1611910847
##########
pkg/scheduler/objects/sorters_test.go:
##########
@@ -209,6 +218,13 @@ func TestSortAppsFifo(t *testing.T) {
// fifo - apps should come back in order created 0, 1, 2, 3
list = sortApplications(input, policies.FifoSortPolicy, false, nil)
assertAppList(t, list, []int{0, 1, 2, 3}, "fifo simple")
+
+ input["app-1"].askMaxPriority = 3
+ input["app-3"].askMaxPriority = 5
+ input["app-2"].SubmissionTime = input["app-3"].SubmissionTime
+ input["app-1"].SubmissionTime = input["app-3"].SubmissionTime
+ list = sortApplications(input, policies.FifoSortPolicy, false, nil)
+ assertAppList(t, list, []int{0, 2, 3, 1}, "fifo first, priority
second") // 0, 3, 1, 2
Review Comment:
0,3,1,2 or 0,2,3,1?
##########
pkg/scheduler/objects/sorters_test.go:
##########
@@ -209,6 +218,13 @@ func TestSortAppsFifo(t *testing.T) {
// fifo - apps should come back in order created 0, 1, 2, 3
list = sortApplications(input, policies.FifoSortPolicy, false, nil)
assertAppList(t, list, []int{0, 1, 2, 3}, "fifo simple")
+
+ input["app-1"].askMaxPriority = 3
+ input["app-3"].askMaxPriority = 5
+ input["app-2"].SubmissionTime = input["app-3"].SubmissionTime
+ input["app-1"].SubmissionTime = input["app-3"].SubmissionTime
+ list = sortApplications(input, policies.FifoSortPolicy, false, nil)
+ assertAppList(t, list, []int{0, 2, 3, 1}, "fifo first, priority
second") // 0, 3, 1, 2
Review Comment:
Comment vs code: 0,3,1,2 or 0,2,3,1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
