chia7712 commented on code in PR #852:
URL: https://github.com/apache/yunikorn-k8shim/pull/852#discussion_r1622352466
##########
pkg/cache/context.go:
##########
@@ -93,7 +94,7 @@ func NewContextWithBootstrapConfigMaps(apis
client.APIProvider, bootstrapConfigM
ctx := &Context{
applications: make(map[string]*Application),
apiProvider: apis,
- namespace: apis.GetAPIs().GetConf().Namespace,
+ namespace: conf.GetSchedulerConf().Namespace,
Review Comment:
It should be `schedulerconf.GetSchedulerConf()`
##########
pkg/cache/context.go:
##########
@@ -46,6 +46,7 @@ import (
"github.com/apache/yunikorn-k8shim/pkg/common/constants"
"github.com/apache/yunikorn-k8shim/pkg/common/events"
"github.com/apache/yunikorn-k8shim/pkg/common/utils"
+ "github.com/apache/yunikorn-k8shim/pkg/conf"
Review Comment:
We don't need to re-import it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
