pbacsko commented on PR #885: URL: https://github.com/apache/yunikorn-core/pull/885#issuecomment-2150737788
> However, due to strings.Split, which results in an array with a length of at least 1, the following two scenarios are unreachable. Then just simply remove the `if` branch. In fact, even if an empty slice is passed, we do very little extra work, so nothing happens. This is not hot code, so just go ahead and remove the path which is never taken. This also increases coverage in %. In both functions, the early return is an unnecessary optimization. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
