chia7712 commented on code in PR #178:
URL: https://github.com/apache/yunikorn-release/pull/178#discussion_r1632075919
##########
helm-charts/yunikorn/templates/service.yaml:
##########
@@ -30,10 +30,12 @@ spec:
targetPort: http1
protocol: TCP
name: yunikorn-core
+ {{- if .Values.enableWebService }}
Review Comment:
Could you please apply it to ingress also? If there is no web port, we don't
need to configure ingress, right?
##########
helm-charts/yunikorn/README.md:
##########
@@ -106,6 +106,7 @@ The following table lists the configurable parameters of
the YuniKorn chart and
| `web.resources.limits.memory` | Web app memory resource
limit | `500Mi` |
| `embedAdmissionController` | Flag for
enabling/disabling the admission controller | `true`
|
| `enableSchedulerPlugin` | Flag for
enabling/disabling scheduler plugin mode | `false`
|
+| `enableWebService` | Flag for enabling/disabling web
service | `true` |
Review Comment:
please reformat this table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
