rich7420 commented on PR #900:
URL: https://github.com/apache/yunikorn-core/pull/900#issuecomment-2209322966
> @rich7420 Could you please fix following cases?
>
> ```
>
> pkg/scheduler/placement/fixed_rule_test.go:127: Function
'TestFixedRuleParent' is too long (146 > 120) (funlen)
>
> func TestFixedRuleParent(t *testing.T) {
>
> pkg/scheduler/placement/provided_rule_test.go:31: Function
'TestProvidedRulePlace' is too long (124 > 120) (funlen)
>
> func TestProvidedRulePlace(t *testing.T) {
>
> pkg/scheduler/placement/provided_rule_test.go:158: Function
'TestProvidedRuleParent' is too long (158 > 120) (funlen)
>
> func TestProvidedRuleParent(t *testing.T) {
>
> pkg/scheduler/placement/tag_rule_test.go:63: Function 'TestTagRulePlace'
is too long (133 > 120) (funlen)
>
> func TestTagRulePlace(t *testing.T) {
>
> pkg/scheduler/placement/tag_rule_test.go:199: Function 'TestTagRuleParent'
is too long (144 > 120) (funlen)
>
> func TestTagRuleParent(t *testing.T) {
>
> pkg/scheduler/placement/user_rule_test.go:90: Function
'TestUserRuleParent' is too long (142 > 120) (funlen)
>
> func TestUserRuleParent(t *testing.T) {
>
> pkg/scheduler/objects/preemption.go:211: Function 'calculateVictimsByNode'
is too long (133 > 120) (funlen)
>
> func (p *Preemptor) calculateVictimsByNode(nodeAvailable
*resources.Resource, potentialVictims []*Allocation) (int, []*Allocation) {
>
> pkg/scheduler/partition_test.go:3850: Function 'TestUserHeadroom' has too
many statements (89 > 80) (funlen)
>
> func TestUserHeadroom(t *testing.T) {
>
> pkg/scheduler/tests/application_tracking_test.go:48: Function
'TestApplicationHistoryTracking' is too long (124 > 120) (funlen)
>
> ```
Ok! No problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
