SP12893678 commented on PR #901: URL: https://github.com/apache/yunikorn-core/pull/901#issuecomment-2211151141
> Ok, I did a deeper review of the locking changes. > > Quite a few lock/unlock pair can be removed. `ConvertUGI()` and `GetUserGroup()` both return a copy of existing `UserGroup`, so no need to obtain a lock. > > Please see my suggested changes [pbacsko@282ab47](https://github.com/pbacsko/incubator-yunikorn-core/commit/282ab47d9046fd4e4e6e48b0560154e987f030b1) > > I ran the tests with `-race` multiple times and there were no problems. Thanks for having reviewed it and found some unnecessary mutex lock/unlock code. I refer your suggestion to fix it. make test` command also passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
