SophieTech88 commented on code in PR #866: URL: https://github.com/apache/yunikorn-k8shim/pull/866#discussion_r1667865863
########## pkg/cache/context_test.go: ########## @@ -50,15 +50,54 @@ import ( ) const ( - Host1 = "HOST1" - appID1 = "app00001" - appID2 = "app00002" - appID3 = "app00003" - - pod1UID = "task00001" - taskUID1 = "task00001" - pod1Name = "my-pod-1" + Host1 = "host0001" + Host2 = "host0002" + + appID1 = "app00001" + appID2 = "app00002" + appID3 = "app00003" + appID4 = "app00004" + appID5 = "app00005" + appIDUnknown = "app-none-exist" Review Comment: Great. Update to `non_existing_appID` in the new commit. ########## pkg/cache/context_test.go: ########## @@ -50,15 +50,54 @@ import ( ) const ( - Host1 = "HOST1" - appID1 = "app00001" - appID2 = "app00002" - appID3 = "app00003" - - pod1UID = "task00001" - taskUID1 = "task00001" - pod1Name = "my-pod-1" + Host1 = "host0001" + Host2 = "host0002" + + appID1 = "app00001" + appID2 = "app00002" + appID3 = "app00003" + appID4 = "app00004" + appID5 = "app00005" + appIDUnknown = "app-none-exist" Review Comment: Great. Update to `non_existing_appID` in the new commit. Many thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
