ryankert01 opened a new pull request, #873: URL: https://github.com/apache/yunikorn-k8shim/pull/873
… and ensureAppAndTaskCreated() ### What is this PR for? From the review https://github.com/apache/yunikorn-k8shim/pull/864 Change notifyTaskComplete(string, string) to notifyTaskComplete(*Application, string). It removes a number of extra getApplication() calls we really do not need. Similar for ensureAppAndTaskCreated() which is only ever called from this function. Add a parameter to it to make it: ensureAppAndTaskCreated(*v1.Pod, *Application) and only execute application creation if app == nil. ### What type of PR is it? * [ ] - Bug Fix * [ ] - Improvement * [ ] - Feature * [ ] - Documentation * [ ] - Hot Fix * [ ] - Refactoring ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/YUNIKORN-2724 ### How should this be tested? ``` make test ``` github ci ### Screenshots (if appropriate) ### Questions: * [ ] - The licenses files need update. * [ ] - There is breaking changes for older versions. * [ ] - It needs documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
