chia7712 commented on code in PR #875:
URL: https://github.com/apache/yunikorn-k8shim/pull/875#discussion_r1671763642
##########
pkg/client/kubeclient.go:
##########
@@ -138,7 +138,6 @@ func (nc SchedulerKubeClient) Create(pod *v1.Pod) (*v1.Pod,
error) {
}
func (nc SchedulerKubeClient) Delete(pod *v1.Pod) error {
- // TODO make this configurable for pods
Review Comment:
Could you please move this TODO to jira?
##########
test/e2e/framework/helpers/common/utils.go:
##########
@@ -102,7 +103,11 @@ func RandSeq(n int) string {
var letters = []rune("abcdefghijklmnopqrstuvwxyz0123456789")
b := make([]rune, n)
for i := range b {
- b[i] = letters[rand.Intn(len(letters))]
Review Comment:
please add the ignore as we don't need crypt quality
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
