chia7712 commented on code in PR #878:
URL: https://github.com/apache/yunikorn-k8shim/pull/878#discussion_r1682038718
##########
test/e2e/framework/helpers/yunikorn/rest_api_utils.go:
##########
@@ -420,21 +420,21 @@ func GetFailedHealthChecks() (string, error) {
}
func (c *RClient) GetQueue(partition string, queueName string)
(*dao.PartitionQueueDAOInfo, error) {
- queues, err := c.GetQueues(partition)
+ req, err := c.newRequest("GET", fmt.Sprintf(configmanager.QueuePath,
partition, queueName), nil)
if err != nil {
return nil, err
}
- if queueName == "root" {
- return queues, nil
- }
+ // Include the query string 'subtree' to retrieve all queue children by
default for better convenience in E2E tests
Review Comment:
> could have an additional parameter: bool withChildren to remind callers
and avoid potential confusion.
that is good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
