blueBlue0102 opened a new pull request, #880:
URL: https://github.com/apache/yunikorn-k8shim/pull/880

   ### What is this PR for?
   Makefile, by default, checks only the existence of file. Hence, developers 
need to remove tools folder (or call `make distclean`) manually to trigger the 
installation after we update the version of tools.
   
   However, how developers can be aware of the tools updates? Personally, I 
smell fishy from the error of warning, but that could be implicit and noisy :cry
   
   In order to fix that, I'd like to introduce the new folder structure to 
tools folder: 
   
   ```
   /tools/{tool_name}-{version}
   ```
   
   That offers a unique path to each version of tool. Developers will not miss 
the updates anymore.
   
   
   ### What type of PR is it?
   * [x] - Improvement
   
   ### What is the Jira issue?
   
[YUNIKORN-2760](https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-2760)
   
   ### How should this be tested?
   
   Currently, `make tools` is triggered only by `./scripts/run-e2e-tests.sh`
   To verify whether `make tools` checks the tools' versions, call any command 
in `./scripts/run-e2e-tests.sh` or trigger it manually
   
   ### Screenshots (if appropriate)
   
   
![image](https://github.com/user-attachments/assets/b9c8e2c5-4380-4379-b34e-1768e1bec757)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to