chia7712 commented on code in PR #918:
URL: https://github.com/apache/yunikorn-core/pull/918#discussion_r1682552889
##########
pkg/scheduler/partition.go:
##########
@@ -325,12 +325,12 @@ func (pc *PartitionContext) AddApplication(app
*objects.Application) error {
if isRecoveryQueue {
queue, err = pc.createRecoveryQueue()
if err != nil {
- return fmt.Errorf("failed to create recovery
queue %s for application %s", common.RecoveryQueueFull, appID)
+ return fmt.Errorf("failed to create recovery
queue %s for application %s : %w", common.RecoveryQueueFull, appID, err)
}
} else {
queue, err = pc.createQueue(queueName, app.GetUser())
if err != nil {
- return fmt.Errorf("failed to create rule based
queue %s for application %s", queueName, appID)
+ return fmt.Errorf("failed to create rule based
queue %s for application %s : %w", queueName, appID, err)
Review Comment:
We decided to use `Join` instead of `%w`, so please give love to `join`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
