pbacsko commented on code in PR #864:
URL: https://github.com/apache/yunikorn-k8shim/pull/864#discussion_r1686237693
##########
pkg/cache/task.go:
##########
@@ -599,3 +601,9 @@ func (task *Task) failWithEvent(errorMessage, actionReason
string) {
events.GetRecorder().Eventf(task.pod.DeepCopy(),
nil, v1.EventTypeWarning, actionReason, actionReason,
errorMessage)
}
+
+func (task *Task) setTaskPod(pod *v1.Pod) {
Review Comment:
Note sure what you mean? I think you're probably referring to the suggestion
of removing the pod reference from Task itself entirely and retrieving from the
scheduler cache. That's possible but it's far more work. This is way simpler.
Also, as long as the task object exists in memory, I think it's better to keep
the pod reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
