pbacsko commented on code in PR #897:
URL: https://github.com/apache/yunikorn-core/pull/897#discussion_r1686820057
##########
pkg/webservice/dao/application_info.go:
##########
@@ -44,6 +48,14 @@ type ApplicationDAOInfo struct {
MaxRequestPriority int32
`json:"maxRequestPriority,omitempty"`
}
+type ApplicationDetailsDAOInfo struct {
Review Comment:
Apologies for the late review, I was on vacation for 2 weeks.
I'd rather put this in `ApplicationDAOInfo`. In fact, retrieving the summary
is a fast operation, so I'm not sure that we need `details=true/false` in the
URL. Unless there's an objection from someone, I'd just add these new fields to
the existing `ApplicationDAOInfo`. This makes things simpler and we don't have
multiple branches to test.
##########
pkg/webservice/dao/application_info.go:
##########
@@ -44,6 +48,14 @@ type ApplicationDAOInfo struct {
MaxRequestPriority int32
`json:"maxRequestPriority,omitempty"`
}
+type ApplicationDetailsDAOInfo struct {
Review Comment:
Apologies for the late review, I was on vacation for 2 weeks.
I'd rather put this inside `ApplicationDAOInfo`. In fact, retrieving the
summary is a fast operation, so I'm not sure that we need `details=true/false`
in the URL. Unless there's an objection from someone, I'd just add these new
fields to the existing `ApplicationDAOInfo`. This makes things simpler and we
don't have multiple branches to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
