chenyulin0719 commented on code in PR #885:
URL: https://github.com/apache/yunikorn-k8shim/pull/885#discussion_r1696369723
##########
pkg/cache/context.go:
##########
@@ -951,6 +951,12 @@ func (ctx *Context) updateApplicationTags(request
*AddApplicationRequest, namesp
}
}
+ // add maxApps resource info as an app tag
+ maxApps := utils.GetNamespaceMaxAppsFromAnnotation(namespaceObj)
+ if maxApps != "" {
+ request.Metadata.Tags[siCommon.AppTagNamespaceResourceMaxApps]
= maxApps
Review Comment:
The comment of this function should include "namespace.resourcemaxapps".
Besides, the "namespace.resourceguaranteed" looks like missing in the previous
change.
```
// update application tags in the AddApplicationRequest based on the
namespace annotation
// adds the following tags to the request based on annotations (if exist):
// - namespace.resourcequota
// - namespace.parentqueue
// - namespace.resourceguaranteed
// - namespace.resourcemaxapps
func (ctx *Context) updateApplicationTags(request *AddApplicationRequest,
namespace string) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
