pbacsko commented on code in PR #928:
URL: https://github.com/apache/yunikorn-core/pull/928#discussion_r1701865299
##########
pkg/scheduler/partition_test.go:
##########
@@ -2004,7 +2005,7 @@ func TestPreemption(t *testing.T) {
assertPreemptedResource(t, appSummary, -1, 5000)
appSummary = app2.GetApplicationSummary("default")
- assertPreemptedResource(t, appSummary, -1, 0)
+ assert.Assert(t,
appSummary.PreemptedResource.TrackedResourceMap["UNKNOWN"] == nil)
Review Comment:
Note: since it's no longer `map[string]map[string]int64` but
`map[string]*Resource`, referencing a non-existing key results in a panic (this
does not happen in the former case, even if `map[string]int64` for a given key
was not created with `make()`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
