wilfred-s commented on code in PR #923:
URL: https://github.com/apache/yunikorn-core/pull/923#discussion_r1703704326
##########
pkg/common/resources/resources.go:
##########
@@ -884,6 +918,29 @@ func ComponentWiseMinPermissive(left, right *Resource)
*Resource {
return out
}
+// ComponentWiseMinPermissiveWithPrecedence Returns a new Resource by giving
higher precedence for resource type values present in left when
+// it is present at right as well. Resource type not present in left and
present in right would be included too.
+// If either Resource passed in is nil the other Resource is returned
+// If a Resource type is missing from one of the Resource, it is considered
empty and the quantity from the other Resource is returned
+func ComponentWiseMinPermissiveWithPrecedence(left, right *Resource) *Resource
{
Review Comment:
not the right name we need something better.
At the moment I do not see this covering the action it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
