wilfred-s commented on PR #933: URL: https://github.com/apache/yunikorn-core/pull/933#issuecomment-2274901760
> +1 on the approach, though I agree we should align AddOnlyExisting() and SubOnlyExisting() to one style or another. SubOnlyExisting I think should move to returning a new object. Looking at the code it will remove a number of `Clone()` calls as the original base can not be changed in most use cases. Using a new empty resource and then adding what is needed is as performant as the clone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
