zhuqi-lucas commented on code in PR #927:
URL: https://github.com/apache/yunikorn-core/pull/927#discussion_r1713357092
##########
pkg/scheduler/objects/allocation_test.go:
##########
@@ -465,3 +465,33 @@ func TestNewAllocFromSI(t *testing.T) {
assert.Assert(t, !alloc.IsAllowPreemptSelf(), "alloc should not have
allow-preempt-self set")
assert.Assert(t, !alloc.IsAllowPreemptOther(), "alloc should not have
allow-preempt-other set")
}
+
+func TestGetUint64Tag(t *testing.T) {
Review Comment:
Good catch @wilfred-s , addressed in latest PR.
##########
pkg/scheduler/objects/queue.go:
##########
@@ -452,6 +451,15 @@ func (sq *Queue) SetResources(guaranteedResource,
maxResource *resources.Resourc
sq.setResources(guaranteedResource, maxResource)
}
+func (sq *Queue) SetMaxRunningApps(maxApps uint64) {
Review Comment:
Add back the comments in latest PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
