craigcondit commented on PR #896: URL: https://github.com/apache/yunikorn-k8shim/pull/896#issuecomment-2295242700
I wasn't aware we were setting 3 seconds currently. This is wrong; we shouldn't be overriding pod settings in deletion like that. The real fix here is to remove the 3 second override. Imagine if we delete a non-placeholder pod such as a database: Forcing non-graceful termination after 3 seconds could lead to data corruption. The override has no place in the generic Delete() call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
