wilfred-s commented on code in PR #935:
URL: https://github.com/apache/yunikorn-core/pull/935#discussion_r1732047310
##########
pkg/scheduler/objects/sorters.go:
##########
@@ -65,8 +65,10 @@ func sortQueuesByPriorityAndFairness(queues []*Queue) {
if lPriority < rPriority {
return false
}
- comp :=
resources.CompUsageRatioSeparately(l.GetAllocatedResource(),
l.GetGuaranteedResource(),
- r.GetAllocatedResource(), r.GetGuaranteedResource())
+
Review Comment:
We can defer that to the next release. It is not just a question of
performance but also a question about correctness. Since the queue values can
change it might be the case that a parents' setting changes. If that happens
between the child checks, specially when you have a larger number of children,
you might not have the exact same inputs for each child computation.
The chance is low but we should try an prevent that.
The change would not be in the sorter but in the queue code when we build
the `fairMaxResources` slice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
