chenyulin0719 commented on code in PR #464: URL: https://github.com/apache/yunikorn-site/pull/464#discussion_r1733936388
########## docs/user_guide/queue_config.md: ########## @@ -265,7 +271,19 @@ The star "*" is the wildcard character and matches all users or groups. Duplicate entries in the lists are ignored and do not cause a parsing error. Specifying a star beside other list elements is not allowed. When a wildcard group is configured, a limit must be configured with at least one named group. -Parsing will reject the configuration with limits that do not follow this rule. + +Valid User name: + +* must start with lower case or upper case alphabet, +* followed by alphanumeric character ([a-z0-9A-Z]), underscores (_), colons (:), hashes (#), slashes (/), ampersands (&), dots (.), and dashes (-). Review Comment: Ditto, no "ampersands (&)", should it be @? > var UserRegExp = regexp.MustCompile(`^[_a-zA-Z][a-zA-Z0-9:#/_.@-]*[$]?$`) ([Link](https://github.com/apache/yunikorn-core/blob/6939b13d1d0e65aef18722ef546413f3e1775be2/pkg/common/configs/configvalidator.go#L77)) ########## docs/user_guide/queue_config.md: ########## @@ -143,7 +143,13 @@ The name of a queue must be unique at the level that the queue is defined. Since the queue structure is fully hierarchical queues at different points in the hierarchy may have the same name. As an example: the queue structure `root.testqueue` and `root.parent.testqueue` is a valid structure. A queue cannot contain a dot "." character as that character is used to separate the queues in the hierarchy. -If the name is not unique for the queue in the configuration or contains a dot a parsing error is generated and the configuration is rejected. + +Valid Queue name: + +* must be 64 characters or less, +* could contain alphanumeric character ([a-z0-9A-Z]), underscores (_), colons (:), hashes (#), slashes (/), ampersands (&), and dashes (-). Review Comment: @manirajv06 no "ampersands (&)", should it be @? > var QueueNameRegExp = regexp.MustCompile(`^[a-zA-Z0-9_:#/@-]{1,64}$`) ([Link](https://github.com/apache/yunikorn-core/blob/6939b13d1d0e65aef18722ef546413f3e1775be2/pkg/common/configs/configvalidator.go#L72C1-L73C1)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
