manirajv06 commented on code in PR #944:
URL: https://github.com/apache/yunikorn-core/pull/944#discussion_r1734395589
##########
pkg/scheduler/objects/preemption_queue_test.go:
##########
@@ -24,6 +24,35 @@ import (
"github.com/apache/yunikorn-core/pkg/common/resources"
)
+var smallestRes =
resources.NewResourceFromMap(map[string]resources.Quantity{"first": 5})
+var childRes =
resources.NewResourceFromMap(map[string]resources.Quantity{"second": 5})
+var smallestResPlusChildRes = resources.Add(smallestRes, childRes)
+var smallestResDouble = resources.Multiply(smallestRes, 2)
+var smallestResDoublePlusChildRes =
resources.Add(resources.Multiply(smallestRes, 2), childRes)
+var smallestResMultiplyByZero =
resources.NewResourceFromMap(map[string]resources.Quantity{"first": 0})
+var smallestResMultiplyByMinusOne = resources.Multiply(smallestRes, -1)
+var smallestResMultiplyByMinusOnePlusChildRes =
resources.Add(resources.Multiply(smallestRes, -1), childRes)
+var childResMultiplyByZero =
resources.NewResourceFromMap(map[string]resources.Quantity{"second": 0})
+var childResMultiplyByMinusOne = resources.Multiply(childRes, -1)
+var childResDouble = resources.Multiply(childRes, 2)
+var smallestResDoublePlusChildResDouble =
resources.Add(resources.Multiply(smallestRes, 2), childResDouble)
+var smallestResPlusChildResDouble = resources.Add(smallestRes, childResDouble)
+var smallestResMultiplyByZeroPluschildResMultiplyByZero =
resources.Add(smallestResMultiplyByZero, childResMultiplyByZero)
+var smallestResMultiplyByZeroPluschildResMultiplyByMinusOne =
resources.Add(smallestResMultiplyByZero, childResMultiplyByMinusOne)
Review Comment:
Simplified the variable names like usual test variables. Couple of jiras
[YUNIKORN-2848 ](https://issues.apache.org/jira/browse/YUNIKORN-2848 )&
[YUNIKORN-2824](https://issues.apache.org/jira/browse/YUNIKORN-2824 ) has been
already raised which would re-use these variables eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
