rrajesh-cloudera commented on code in PR #906:
URL: https://github.com/apache/yunikorn-k8shim/pull/906#discussion_r1744852113
##########
test/e2e/user_group_limit/user_group_limit_test.go:
##########
@@ -641,6 +641,40 @@ var _ = ginkgo.Describe("UserGroupLimit", func() {
checkUsage(groupTestType, url.QueryEscape(validGroup),
sandboxQueue1, []*v1.Pod{usergroup1Sandbox1Pod1})
})
+ ginkgo.It("Verify_Queue_Name_With_Special_Characters", func() {
+ ginkgo.By("Create a queue with a name that includes all allowed
special characters")
+ queueName := "queue-#_@/:"
+
+ yunikorn.UpdateCustomConfigMapWrapper(oldConfigMap, "", func(sc
*configs.SchedulerConfig) error {
+ // remove placement rules so we can control queue
+ sc.Partitions[0].PlacementRules = nil
+
+ var err error
+ if err = common.AddQueue(sc, "default", "root",
configs.QueueConfig{
+ Name: queueName,
+ Resources: configs.Resources{Guaranteed:
map[string]string{"memory": fmt.Sprintf("%dM", 200)}},
+ Properties:
map[string]string{"preemption.delay": "1s"},
+ }); err != nil {
+ return err
+ }
+ return nil
+ })
+ ginkgo.By("Fetch the queue information using the REST API")
+ allQueues, err := restClient.GetQueues("default")
Review Comment:
Hi @manirajv06 , Updated the code with URL Encoded and Negative case as
well. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
