dcoric commented on PR #198: URL: https://github.com/apache/yunikorn-web/pull/198#issuecomment-2340532083
> @dcoric Overall LGTM, the functionality work as expected. Below new files are missing license. > > 1. webpack.config.js > 2. webpack.prod.config.js > > The license-check command Makefile is not checking js files, could you add it too? > > * https://github.com/apache/yunikorn-web/blob/3922c51d7bc06c548317712ed4ac93cec9cbb7da/Makefile#L197-L200 I have added missing licenses and updated Makefile to check *.js files as well (with exception to /dist folder) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
