pbacsko commented on code in PR #914: URL: https://github.com/apache/yunikorn-k8shim/pull/914#discussion_r1759437943
########## Makefile: ########## @@ -89,6 +90,16 @@ else REPRO := endif +# Release build requires using parent dir as base for buildroot +RELEASE_BUILD := $(test -f "$(BASE_DIR)/.gitignore" ; echo $?) Review Comment: I tried this locally but it didn't work. Spent some time debugging it, found out that this solves the problem: ``` RELEASE_BUILD := $(shell test -f "$(BASE_DIR)/.gitignore" ; echo $$?) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
