ryankert01 commented on code in PR #971:
URL: https://github.com/apache/yunikorn-core/pull/971#discussion_r1770552316
##########
pkg/scheduler/ugm/queue_tracker.go:
##########
@@ -410,11 +410,7 @@ func (qt *QueueTracker) canRunApp(hierarchy []string,
applicationID string, trac
func (qt *QueueTracker) canBeRemoved() bool {
for _, childQT := range qt.childQueueTrackers {
// quick check to avoid further traversal
- if childQT.canBeRemovedInternal() {
- if !childQT.canBeRemoved() {
Review Comment:
Could you verify it by adding test case with tree that depth >= 3? I think
it's for tree traversal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
