craigcondit commented on code in PR #483: URL: https://github.com/apache/yunikorn-site/pull/483#discussion_r1792124613
########## docs/developer_guide/deployment.md: ########## @@ -30,21 +30,24 @@ scheduler and admission controller. It is primarily intended for developers. ## Build docker image -Under project root of the `yunikorn-k8shim`, run the command to build an image using the map for the configuration: +Under project root of the `yunikorn-k8shim`, run the command to build run the command to build YuniKorn Docker images: + ``` make image ``` -This command will build an image. The image will be tagged with a default version, image tag and your build architecture. - -**Note** the default build uses a hardcoded user and tag. You *must* update the `IMAGE_TAG` variable in the `Makefile` to push to an appropriate repository. +**Note** that the default build uses a hardcoded registry and tag. If you want to build docker image with specific arch, version or registry, you can refer the following command. Review Comment: Grammar: Change "If you want to build docker image with specific arch" to "If you want to build Docker images with a specific arch" and "you can refer the following command." to "you can refer to the following command:" ########## docs/developer_guide/deployment.md: ########## @@ -30,21 +30,24 @@ scheduler and admission controller. It is primarily intended for developers. ## Build docker image -Under project root of the `yunikorn-k8shim`, run the command to build an image using the map for the configuration: +Under project root of the `yunikorn-k8shim`, run the command to build run the command to build YuniKorn Docker images: Review Comment: "run the command" is listed twice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
