SophieTech88 opened a new pull request, #985:
URL: https://github.com/apache/yunikorn-core/pull/985
### What is this PR for?
Off late, lot of new tests has been added into preemption_test.go for
several use cases. There is a room of improvement to simplify the whole tests
especially by avoiding duplicates.
This PR focus on TestTryPreemption, TestTryPreemptionOnNode and
TestTryPreemption_NodeWithCapacityLesserThanAsk, those 3 tests can be merged
together into single one and handle each cases through t.Run({}) construct.
### What type of PR is it?
* [ ] - Bug Fix
* [x ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2824
### How should this be tested?
It should pass all unit tests.
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
