rrajesh-cloudera commented on PR #935: URL: https://github.com/apache/yunikorn-k8shim/pull/935#issuecomment-2456995472
> @rrajesh-cloudera I'm sorry to say but we already have e2e tests. Please see [tests](https://github.com/apache/yunikorn-k8shim/blob/master/test/e2e/foreign_pod/foreign_pod_test.go). Looks like there was a communication issue :/ > > I'll take a look but I don't think we need more tests. > > EDIT: oh, I can see you added the new tests to the same file. Anyway, I'm looking at them. The First one is positive test case which you added , the 2nd is a negative test case for the first in which we are simulating an error where a pod from kube-system is either untracked or incorrectly mapped. The Third case Focuses on ensuring multiple pods from kube-system are all being tracked and 4th case Verifies that foreign pods are accurately tracked across different nodes. Each case targets different potential issues, ensuring comprehensive coverage of the system’s functionality and robustness -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
