wilfred-s opened a new pull request, #993:
URL: https://github.com/apache/yunikorn-core/pull/993

   ### What is this PR for?
   Remove the Resource object from the REST response for the user and group 
trackers. Removed the usage of the DAO objects in the internal unit tests. The 
unit tests use new functions which directly expose the same structures without 
using the DAO.
   
   Cleanup:
   - remove export from internal functions (UserTracker, GroupTracker)
   - renamed functions to match their results (Manager)
   - update handler to call renamed functions in Manager
   - reimplemented test functions to not use DAO objects (Manager, UserTracker, 
GroupTracker, QueueTracker)
   - assert function changes to use new functions removing DAO usage 
(scheduler/utilites_test, scheduler/objects/utilites_test)
   
   ### What type of PR is it?
   * [X] - Bug Fix
   * [X] - Improvement
   * [X] - Refactoring
   
   ### What is the Jira issue?
   * [YUNIKORN-2972](https://issues.apache.org/jira/browse/YUNIKORN-2972)
   
   ### How should this be tested?
   Existing unit test cover the code
   
   NOTE: this will break e2e test, the `user_group_limit_test` uses the DAO 
directly
   
   ### Questions:
   * [X] - There is breaking changes for older versions.
   * [X] - It needs documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to