craigcondit commented on code in PR #224:
URL: https://github.com/apache/yunikorn-web/pull/224#discussion_r1842739427
##########
src/app/components/app-node-utilizations/app-node-utilizations.component.html:
##########
@@ -15,17 +15,30 @@
* See the License for the specific language governing permissions and
* limitations under the License.
-->
-<div class="app-node-utilizations">
- <mat-card-title class="title">Node Resource Utilization</mat-card-title>
- <div class="mat-elevation-z8">
- <mat-card appearance="outlined" class="box-card">
- <mat-card-content>
- <div class="status-wrapper flex-grid">
- <div class="chart-wrapper flex-primary">
- <app-vertical-bar-chart [bucketList]="bucketList"
[barChartDataSets]="barChartDataSets" />
- </div>
- </div>
- </mat-card-content>
- </mat-card>
+
+ <app-card class="app-node-utilizations">
+ <ng-container header>
+ <div>
+ <i class="fa fa-chart-column" aria-hidden="true"></i>
+ Node Resource Utilization
+ </div>
+ <div>
+ <mat-form-field appearance="outline" class="partition-selector">
+ <mat-label>Partition</mat-label>
Review Comment:
Is it possible to prevent typing in this field? There will almost always be
only a single partition.
##########
src/app/components/app-node-utilizations/app-node-utilizations.component.scss:
##########
@@ -16,13 +16,22 @@
* limitations under the License.
*/
- .app-node-utilizations {
+::ng-deep .app-node-utilizations {
+ .card-wrapper {
+ max-width: 800px;
Review Comment:
I don't think we should have a max-width here. With lots of resource types,
the extra horizontal real estate can be nice to have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
