brandboat commented on code in PR #995:
URL: https://github.com/apache/yunikorn-core/pull/995#discussion_r1843529448
##########
pkg/scheduler/objects/queue.go:
##########
@@ -693,8 +693,14 @@ func (sq *Queue) GetPartitionQueueDAOInfo(include bool)
dao.PartitionQueueDAOInf
queueInfo.IsManaged = sq.isManaged
queueInfo.CurrentPriority = sq.getCurrentPriority()
queueInfo.TemplateInfo = sq.template.GetTemplateInfo()
- queueInfo.AbsUsedCapacity = resources.CalculateAbsUsedCapacity(
- sq.maxResource, sq.allocatedResource).DAOMap()
+ queueInfo.AbsUsedCapacity =
resources.CalculateAbsUsedCapacity(sq.maxResource,
sq.allocatedResource).DAOMap()
+ queueInfo.SortingPolicy = sq.sortType.String()
+ queueInfo.PrioritySorting = sq.prioritySortEnabled
+ queueInfo.PreemptionEnabled = sq.preemptionPolicy ==
policies.DisabledPreemptionPolicy
Review Comment:
I am a bit misleading here, does `PreemptionEnabled = true` means the
preemptionPolicy is disabled ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
