wilfred-s commented on PR #996: URL: https://github.com/apache/yunikorn-core/pull/996#issuecomment-2481872475
> Is it possible to have at least a single unit test that fails with the old code and passes with this PR? I think the missing bit is just a single line: ``` 928 alloc.SetNodeID(targetNodeID) ``` We need a unit tests, and it should be doable to create one: * fill up a node with allocations * create a request that does not fit on the used node * manually create a reservation for that request on that filled up node * run the normal allocation and get it to allocate on the "other" node. * the new allocation should show the correct node. Before the fix the allocation will show the reserved node ID or none at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
