craigcondit commented on code in PR #998: URL: https://github.com/apache/yunikorn-core/pull/998#discussion_r1850678135
########## pkg/common/errors.go: ########## @@ -27,3 +27,4 @@ const PreemptionPreconditionsFailed = "Preemption preconditions failed" const PreemptionDoesNotGuarantee = "Preemption queue guarantees check failed" const PreemptionShortfall = "Preemption helped but short of resources" const PreemptionDoesNotHelp = "Preemption does not help" +const NoVictimForRequiredNode = "RequiredNode preemption failed, no victim found" Review Comment: Can we improve the wording to not use internal camelcase names? Maybe "No fit on required node, preemption does not help" or something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
